-
Notifications
You must be signed in to change notification settings - Fork 843
Grid wrapper example for CSS Layout Cookbook #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi Michelle, thanks for the new recipe! @rachelandrew , do you want to give this a quick review? We'll also need a page adding to https://developer.mozilla.org/en-US/docs/Web/CSS/Layout_cookbook, to cover it, using the sample template Rachel used for the others. Are you OK to write one? |
Hi @chrisdavidmills, yes I’m happy to create a page – I‘ll just need page-creation permission for my account :) Thanks! |
Sure thing. What's your MDN username? |
It’s mbarker84, same as my Github. Thanks! |
OK, you've now got the necessary permissions. Cheers for the contribution! And feel free to ping me if you have questions. |
Thanks @chrisdavidmills, I’ve got a few things written up, will wait to see if this PR is merged before submitting a page |
I'm gonna merge this; it looks useful and works nicely. Thanks @mbarker84 ! |
Thanks @chrisdavidmills, the page is now live, in case you or anyone else want to review :) |
Great work Michelle, thanks! I have given it a review, and made a few edits. You might want to give it another read through to make sure you are happy with my edits. Looks fine, apart from one minor comment. In the first code block in the "Useful fallbacks or alternative methods" section, shouldn't you set |
Thanks so much for reviewing @chrisdavidmills, and yes, that totally makes sense. I usually only put the rules that I need to override inside |
Lovely, we are all sorted then. Thanks again for the awesome contribution! |
This is a pattern I use a lot with CSS Grid, consisting of a number of central columns with a maximum width, and a flexible column either side. It enables you to align grid items to the central wrapper or break them out to edge of the grid. I find it really useful and use it on practically every project, so I’d love to contribute it to the Layout Cookbook.